Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): default vitest provider to v8 #18515

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

mandarini
Copy link
Member

Current Behavior

vitest provider defaults to c8.

Expected Behavior

vitest generator defaults to v8. Executor should default to v8, but if c8 is installed then use c8. User can override these options in vite.config.ts.

Related Issue(s)

Fixes #18505

@mandarini mandarini requested a review from a team as a code owner August 7, 2023 12:52
@mandarini mandarini requested a review from jaysoo August 7, 2023 12:52
@mandarini mandarini self-assigned this Aug 7, 2023
@vercel
Copy link

vercel bot commented Aug 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2023 0:56am

@mandarini mandarini requested review from ndcunningham and removed request for jaysoo August 7, 2023 12:52
Copy link
Contributor

@ndcunningham ndcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mandarini mandarini merged commit ff04be5 into nrwl:master Aug 8, 2023
15 checks passed
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2023
@mandarini mandarini deleted the fix/vitest-default-v8 branch August 22, 2023 12:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: "coverage.provider: c8" is not supported anymore. Use "coverage.provider: v8" instead
2 participants