feat(testing): update to jest-preset-angular v8.0.0

[JoshMentzer]

Current Behavior (This is the behavior we have today, before the PR is merged)

• jest-preset-angular is v7.0.0
• Upgrading jest-preset-angular to v8.0.0 causes any tests for Angular projects using Jest to fail to run

Expected Behavior (This is the new behavior we can expect after the PR is merged)

• jest-preset-angular is v8.0.0
• Tests for Angular projects using Jest should execute successfully

Issue

#1979

[minijus]

Right now it is not possible to modify these options from local workspace config. Would it make sense having jest.config.js and jest-ng.config.js in root dir of workspace?

jest-ng.config.js:

module.exports = {
  preset: './jest.config.js',
  stringifyContentPathRegex: '\\.(html|svg)$',
  astTransformers: [
    'jest-preset-angular/build/InlineFilesTransformer',
    'jest-preset-angular/build/StripStylesTransformer'
  ],
  snapshotSerializers: [
    'jest-preset-angular/build/AngularSnapshotSerializer.js',
    'jest-preset-angular/build/HTMLCommentSerializer.js'
  ]
};

and then libs/dummy/jest.config.js:

module.exports = {
  name: 'dummy',
  preset: '../../jest-ng.config.js',
  coverageDirectory: '../../coverage/libs/dummy'
};

[JoshMentzer]

I can see the sense of your suggestion, think that's more of a design decision would want maintainers to weigh in on; may also be more of its own PR vs part of this one as this is focused on just updating a dependency, like for like.

[JoshMentzer]

I'm unsure why the yarn.lock changes other than as it regards to the new jest-preset-angular; after cloning and doing yarn majority of those changes showing up without modification to package.json

[wtho]

jest-preset-angular maintainer here.
We added a new Serializer, which serializes components in a nicer way, stripping away dev-only ng-* attributes. I do not know if it should be enabled in nx by default, but we generally do recommend to enable it from our side.

Just throwing this in here, could also happen in a different PR of course.

Cheers!

[vsavkin]

@JoshMentzer thank you for your PR. Could you integrate the new serializer in this PR?

[JoshMentzer]

@JoshMentzer thank you for your PR. Could you integrate the new serializer in this PR?

Sure thing, can probably do that later tonight.

[listepo]

@JoshMentzer any news?

[edbzn]

Hi, waiting this to migrate.

[vsavkin]

@JoshMentzer any update?

[vandermore]

This is a much needed update for the project I am on right now. Any update on the status?

[JoshMentzer]

Hey all, sorry for long delay on getting this updated to include the new serializer; I plan on getting it in this week

[mehrad-rafigh]

Hi @JoshMentzer Are you able to integrate the changes into your PR? Otherwise, I would open a PR, because we really need that feature and cannot really wait for any longer

[wtho]

Maybe JoshMentzer can add you as collaborator on his fork, so you can add a commit to the branch?

[demisx]

Any update please? It's blocking our work too.

[overlineink]

Hey @demisx 👋, according with the issue, you can performe the changes available in this PR locally till it get passed.

[overlineink]

@JoshMentzer 👋 I hope are you doing well! Are you working on it? If not maybe some of us are free to help solve the conflicts.

[mehrad-rafigh]

Hi everyone, I opened a new PR addressing this issue.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.