Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): support yaml for flat config conversion #20022

Merged
merged 6 commits into from
Nov 22, 2023

Conversation

meeroslav
Copy link
Contributor

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

Copy link

vercel bot commented Nov 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2023 10:53am

@meeroslav meeroslav self-assigned this Nov 2, 2023
@meeroslav meeroslav added the scope: linter Issues related to Eslint support in Nx label Nov 2, 2023
@meeroslav meeroslav force-pushed the feat-eslint-add-support-for-yaml branch from 3475447 to b119243 Compare November 16, 2023 12:19
@meeroslav meeroslav marked this pull request as ready for review November 16, 2023 12:19
@meeroslav meeroslav requested a review from a team as a code owner November 16, 2023 12:19
@meeroslav meeroslav changed the title feat(linter): support yaml for flat config conversion WIP feat(linter): support yaml for flat config conversion Nov 16, 2023
@meeroslav meeroslav force-pushed the feat-eslint-add-support-for-yaml branch 2 times, most recently from 80d848b to b647ea1 Compare November 17, 2023 10:04
Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocker is .yml support, optional for this PR is exploring the newline spacing in converted output

@meeroslav meeroslav force-pushed the feat-eslint-add-support-for-yaml branch from 8cc34cd to c6dafb6 Compare November 22, 2023 10:52
@meeroslav meeroslav requested a review from a team as a code owner November 22, 2023 10:52
@JamesHenry
Copy link
Collaborator

Changes LGTM but triggered re-run of CI to try and get it green first

@meeroslav meeroslav merged commit d1a213f into nrwl:master Nov 22, 2023
6 checks passed
@meeroslav meeroslav deleted the feat-eslint-add-support-for-yaml branch November 22, 2023 19:37
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: linter Issues related to Eslint support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants