Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(angular): use esm2022 for secondary entrypoints in ng-packagr-lite executor #20130

Merged
merged 3 commits into from
Nov 14, 2023
Merged

fix(angular): use esm2022 for secondary entrypoints in ng-packagr-lite executor #20130

merged 3 commits into from
Nov 14, 2023

Conversation

skrtheboss
Copy link
Contributor

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@skrtheboss skrtheboss requested a review from a team as a code owner November 8, 2023 16:54
@vercel Vercel
Copy link

vercel bot commented Nov 8, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Nov 14, 2023 3:11pm

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Nov 8, 2023 •
edited

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8886a7c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

@atsjo
Copy link

atsjo commented Nov 14, 2023

still can't build my angular project with incremental esbuild and a library with secondary entrypoints... I guess this is the fix for that, as this is supposed to be fixed in ng-packagr now...

@leosvelperez leosvelperez self-assigned this Nov 14, 2023
leosvelperez
leosvelperez requested changes Nov 14, 2023
View reviewed changes
Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

This is a good catch. I left a comment with a suggested change. We need to account for the differences between the supported Angular versions.

...ors/ng-packagr-lite/ng-packagr-adjustments/ng-package/entry-point/write-package.transform.ts Outdated Show resolved Hide resolved
@leosvelperez leosvelperez changed the title fix(core): use esm2022 instead of fesm2022 for secondary entrypoints in ng-package-lite fix(angular): use esm2022 for secondary entrypoints in ng-packagr-lite executor Nov 14, 2023
@leosvelperez leosvelperez enabled auto-merge (squash) November 14, 2023 15:31
@leosvelperez leosvelperez merged commit 96043fb into nrwl:master Nov 14, 2023
6 checks passed
FrozenPandaz pushed a commit that referenced this pull request Nov 14, 2023
@skrtheboss @FrozenPandaz
fix(angular): use esm2022 for secondary entrypoints in ng-packagr-lit…
8bf3199 
…e executor (#20130)

Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>
(cherry picked from commit 96043fb)
@skrtheboss skrtheboss deleted the fix/use-correct-budle-in-ng-packager-lite-secondary-entrypoints branch November 14, 2023 18:53
@github-actions GitHub Actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leosvelperez leosvelperez leosvelperez approved these changes

@FrozenPandaz FrozenPandaz Awaiting requested review from FrozenPandaz FrozenPandaz is a code owner automatically assigned from nrwl/nx-angular-reviewers

Assignees

@leosvelperez leosvelperez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skrtheboss @atsjo @leosvelperez