-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nextjs): Add support for create nodes for nextjs #20193
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a0b4507. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
3f6b838
to
6af2372
Compare
8a9fce4
to
04bc623
Compare
d8cc774
to
3104e75
Compare
@@ -94,6 +94,6 @@ describe('Next.js Webpack', () => { | |||
expect(() => { | |||
runCLI(`build ${appName}`); | |||
}).not.toThrow(); | |||
checkFilesExist(`apps/${appName}/.next/build-manifest.json`); | |||
checkFilesExist(`dist/apps/${appName}/.next/build-manifest.json`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build
only creates production artifacts so this test case was wrong before.
f6d4619
to
3a76a1c
Compare
605712b
to
ecf922a
Compare
322568e
to
7ef5b07
Compare
Added some comments. I think the rest looks fine. |
2c24128
to
507a32e
Compare
507a32e
to
33fa5ac
Compare
We'll need to check what's still needed from |
33fa5ac
to
2185085
Compare
Updated:
|
ff10879
to
0fdf87b
Compare
0fdf87b
to
b97daf0
Compare
b97daf0
to
a0b4507
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
There is no plugin to run Nextjs projects (a project containing
next.config.js
)Expected Behavior
Using this plugin
@nx/next/plugin
inside a fresh will create targets (build
,start
&dev
) tonx.json
.The user should now be able to run these targets without configuring a
project.json
.How to Use
Add this to your
nx.json
pluginsFor new projects when you create a Nextjs project this will already be set up for you after passing
NX_PCV3=true
.NX_PCV3=true nx generate @nx/next:app ${appName} --project-name-and-root-format=as-provided --no-interactive
NB
next export
has been deprecated in favor of: