Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): adjust config generation #20367

Merged
merged 5 commits into from
Nov 29, 2023

Conversation

mandarini
Copy link
Member

@mandarini mandarini commented Nov 22, 2023

This PR makes sure that vite executors are ready to be "removed"/"inferred", and that the vite.config.ts files which we generate are ready for pcv3.

There were a lot of hard-coded values in the executors, and some assumptions and inferrals being made within the executors, which caused some issues when trying to use the same config with pcv3.

Goal is to align executors with vite build etc, and make sure the generated vite.config.ts file can work both with vite cli and our executors consistently.

This is an effort to make our @nx/vite package pcv3-ready.

Migrations have been added to add the extra config needed in vite.config.ts. Other than that, the user should not see any difference.

by the way @FrozenPandaz this should go in a minor release, not a patch. it has quite some changes! 😅

Copy link

vercel bot commented Nov 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Nov 29, 2023 1:02pm

@mandarini mandarini self-assigned this Nov 22, 2023
@mandarini mandarini force-pushed the fix/adjustments-vite-config-1 branch 10 times, most recently from 9dbf060 to f0873b8 Compare November 23, 2023 14:22
@mandarini mandarini merged commit 2c88282 into nrwl:master Nov 29, 2023
6 checks passed
Copy link

github-actions bot commented Dec 5, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants