-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vite): adjust config generation #20367
fix(vite): adjust config generation #20367
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f162a72. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
5332e3b
to
1ed102f
Compare
184f6ef
to
54f208b
Compare
a9436f2
to
1f4ffab
Compare
1f4ffab
to
3e046fa
Compare
3e046fa
to
87c0b85
Compare
9dbf060
to
f0873b8
Compare
f0873b8
to
69eb693
Compare
69eb693
to
abbd4d4
Compare
8ae1e8f
to
0937cf1
Compare
0937cf1
to
9059af5
Compare
9059af5
to
82bdc64
Compare
e829b73
to
771e382
Compare
771e382
to
928fc98
Compare
60a3642
to
b3172bb
Compare
b3172bb
to
95c5113
Compare
95c5113
to
f162a72
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This PR makes sure that vite executors are ready to be "removed"/"inferred", and that the
vite.config.ts
files which we generate are ready for pcv3.There were a lot of hard-coded values in the executors, and some assumptions and inferrals being made within the executors, which caused some issues when trying to use the same config with pcv3.
Goal is to align executors with
vite build
etc, and make sure the generatedvite.config.ts
file can work both withvite
cli and our executors consistently.This is an effort to make our
@nx/vite
packagepcv3
-ready.Migrations have been added to add the extra config needed in
vite.config.ts
. Other than that, the user should not see any difference.by the way @FrozenPandaz this should go in a minor release, not a patch. it has quite some changes! 😅