Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): fix flat config file paths #20386

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

meeroslav
Copy link
Contributor

Current Behavior

The file paths after flat config conversion are set to {projectRoot}/**/*.{extension}. This works perfectly for running linter via @nx/eslint executor or when running for the root, but fails to find any files when running eslint from within the project:

cd path/to/project
ESLINT_USE_FLAT_CONFIG=true npx eslint .

since ESlint would be trying to look for files path/to/project/path/to/project/**/*.{extension}

Expected Behavior

The config should work also for manual running of eslint from within the project

Related Issue(s)

Fixes #

@meeroslav meeroslav self-assigned this Nov 23, 2023
@meeroslav meeroslav requested review from a team as code owners November 23, 2023 12:14
Copy link

vercel bot commented Nov 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2023 0:15am

@meeroslav meeroslav merged commit 905ef65 into nrwl:master Nov 23, 2023
6 checks passed
@meeroslav meeroslav deleted the fix-flat-config-file-paths branch November 23, 2023 20:43
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants