-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webpack): Fixed libraryTarget option not being set for node targets #20505
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 89e8031. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
@ndcunningham looks like the ci timed out? |
…gets closed nrwl#20349, #TriPSs/nx-extend/182
@ndcunningham / @JamesHenry can this be checked? This fix together with #20192 are blocking our releases. |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
When #19984 got merged it changed the implementation of Webpack.
Expected Behavior
For node projects to compile like they always did.
Related Issue(s)
Fixes #20349
Fixes TriPSs/nx-extend#182