Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): Fixed libraryTarget option not being set for node targets #20505

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

TriPSs
Copy link
Contributor

@TriPSs TriPSs commented Nov 30, 2023

Current Behavior

When #19984 got merged it changed the implementation of Webpack.

Expected Behavior

For node projects to compile like they always did.

Related Issue(s)

Fixes #20349
Fixes TriPSs/nx-extend#182

@TriPSs TriPSs requested a review from a team as a code owner November 30, 2023 15:47
Copy link

vercel bot commented Nov 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 1, 2023 0:51am

@TriPSs
Copy link
Contributor Author

TriPSs commented Nov 30, 2023

@ndcunningham looks like the ci timed out?

@TriPSs
Copy link
Contributor Author

TriPSs commented Dec 1, 2023

@ndcunningham / @JamesHenry can this be checked? This fix together with #20192 are blocking our releases.

@JamesHenry
Copy link
Collaborator

@TriPSs Nicholas and/or @jaysoo will get back to you on this very soon

@jaysoo jaysoo merged commit a08fdf0 into nrwl:master Dec 4, 2023
6 checks passed
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants