Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): check if eslint plugin exists before adding target #20510

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

mandarini
Copy link
Member

only check NX_PCV3 on init generator. In other generators check if plugin exists.

@mandarini mandarini requested a review from a team as a code owner November 30, 2023 17:34
Copy link

vercel bot commented Nov 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Nov 30, 2023 5:34pm

@mandarini mandarini self-assigned this Nov 30, 2023
Copy link
Contributor

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be fixed on init project but rather on init function.

If plugin driven target is requested but it's missing, we should create it.

@meeroslav meeroslav merged commit 51501c5 into nrwl:master Nov 30, 2023
6 checks passed
Copy link

github-actions bot commented Dec 6, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants