Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): recalculate cypress targets when cypress config changes #20593

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

When the daemon is enabled, the cypress config is loaded from the require cache which means changing the cypress.config.ts doesn't change the project config.

Expected Behavior

The require cache is cleared before loading the cypress.config.ts to ensure that changes are picked up.

I tried to use import() which has a separate cache but had a lot of issues loading .ts files with import()

Related Issue(s)

Fixes #

Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2023 6:21pm

@FrozenPandaz FrozenPandaz changed the title fix(testing): recalculate cypress targets when cypress config chagnes fix(testing): recalculate cypress targets when cypress config changes Dec 5, 2023
@FrozenPandaz FrozenPandaz marked this pull request as ready for review December 6, 2023 18:11
@FrozenPandaz FrozenPandaz requested a review from a team as a code owner December 6, 2023 18:11
@FrozenPandaz FrozenPandaz merged commit 0618ba4 into nrwl:master Dec 6, 2023
6 checks passed
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants