fix(testing): add webServerCommands/ciWebServerCommands option for cy… #20616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e62614c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
jaysoo
reviewed
Dec 7, 2023
| webServerCommands: hasNxBuildPlugin | ||
| ? { | ||
| default: `nx run ${options.projectName}:serve`, | ||
| production: `nx run ${options.projectName}:serve:production`, |
There was a problem hiding this comment.
Production configuration may not be there since the "production" server may be through preview target.
…press configuration
FrozenPandaz
force-pushed
the
cypress-fix
branch
from
6f34803
to
e62614c
Compare
jaysoo
approved these changes
Dec 7, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…press configuration
Current Behavior
The cypress generator looks at the project configuration in the tree to determine if a
serveandserve-statictarget exist. For PCv3, the tree doesn't have the project configuration.Expected Behavior
There is an option which is used over looking at the project configuration in the tree. Apps should pass this in.
Related Issue(s)
Fixes #