Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(release): updateDependents generator option for versioning #21313

Closed
wants to merge 3 commits into from
Closed

feat(release): updateDependents generator option for versioning #21313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eabad43
feat(release): updateDependents generator option for versioning
JamesHenry Jan 23, 2024
ac63d73
chore(release): improvements
JamesHenry Jan 25, 2024
1483e22
chore(release): improvements
JamesHenry Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
308 changes: 241 additions & 67 deletions packages/js/src/generators/release-version/release-version.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,78 +442,252 @@ To fix this you will either need to add a package.json file at that location, or
`);
});

it(`should update dependents even when filtering to a subset of projects which do not include those dependents`, async () => {
expect(readJson(tree, 'libs/my-lib/package.json').version).toEqual(
'0.0.1'
);
expect(
readJson(tree, 'libs/project-with-dependency-on-my-pkg/package.json')
).toMatchInlineSnapshot(`
{
"dependencies": {
"my-lib": "0.0.1",
},
"name": "project-with-dependency-on-my-pkg",
"version": "0.0.1",
}
`);
expect(
readJson(
tree,
'libs/project-with-devDependency-on-my-pkg/package.json'
)
).toMatchInlineSnapshot(`
{
"devDependencies": {
"my-lib": "0.0.1",
},
"name": "project-with-devDependency-on-my-pkg",
"version": "0.0.1",
}
`);
describe('updateDependentsOptions', () => {
it(`should not update dependents when filtering to a subset of projects by default`, async () => {
expect(readJson(tree, 'libs/my-lib/package.json').version).toEqual(
'0.0.1'
);
expect(
readJson(
tree,
'libs/project-with-dependency-on-my-pkg/package.json'
)
).toMatchInlineSnapshot(`
{
"dependencies": {
"my-lib": "0.0.1",
},
"name": "project-with-dependency-on-my-pkg",
"version": "0.0.1",
}
`);
expect(
readJson(
tree,
'libs/project-with-devDependency-on-my-pkg/package.json'
)
).toMatchInlineSnapshot(`
{
"devDependencies": {
"my-lib": "0.0.1",
},
"name": "project-with-devDependency-on-my-pkg",
"version": "0.0.1",
}
`);

await releaseVersionGenerator(tree, {
projects: [projectGraph.nodes['my-lib']], // version only my-lib
projectGraph,
specifier: '9.9.9', // user CLI specifier override set, no prompting should occur
currentVersionResolver: 'disk',
specifierSource: 'prompt',
releaseGroup: createReleaseGroup('independent'),
await releaseVersionGenerator(tree, {
projects: [projectGraph.nodes['my-lib']], // version only my-lib
projectGraph,
specifier: '9.9.9', // user CLI specifier override set, no prompting should occur
currentVersionResolver: 'disk',
specifierSource: 'prompt',
releaseGroup: createReleaseGroup('independent'),
});

expect(readJson(tree, 'libs/my-lib/package.json'))
.toMatchInlineSnapshot(`
{
"name": "my-lib",
"version": "9.9.9",
}
`);

expect(
readJson(
tree,
'libs/project-with-dependency-on-my-pkg/package.json'
)
).toMatchInlineSnapshot(`
{
"dependencies": {
"my-lib": "0.0.1",
},
"name": "project-with-dependency-on-my-pkg",
"version": "0.0.1",
}
`);
expect(
readJson(
tree,
'libs/project-with-devDependency-on-my-pkg/package.json'
)
).toMatchInlineSnapshot(`
{
"devDependencies": {
"my-lib": "0.0.1",
},
"name": "project-with-devDependency-on-my-pkg",
"version": "0.0.1",
}
`);
});

expect(readJson(tree, 'libs/my-lib/package.json'))
.toMatchInlineSnapshot(`
{
"name": "my-lib",
"version": "9.9.9",
}
`);
it(`should not update dependents when filtering to a subset of projects by default, if "when" is set to "auto"`, async () => {
expect(readJson(tree, 'libs/my-lib/package.json').version).toEqual(
'0.0.1'
);
expect(
readJson(
tree,
'libs/project-with-dependency-on-my-pkg/package.json'
)
).toMatchInlineSnapshot(`
{
"dependencies": {
"my-lib": "0.0.1",
},
"name": "project-with-dependency-on-my-pkg",
"version": "0.0.1",
}
`);
expect(
readJson(
tree,
'libs/project-with-devDependency-on-my-pkg/package.json'
)
).toMatchInlineSnapshot(`
{
"devDependencies": {
"my-lib": "0.0.1",
},
"name": "project-with-devDependency-on-my-pkg",
"version": "0.0.1",
}
`);

expect(
readJson(tree, 'libs/project-with-dependency-on-my-pkg/package.json')
).toMatchInlineSnapshot(`
{
"dependencies": {
"my-lib": "9.9.9",
await releaseVersionGenerator(tree, {
projects: [projectGraph.nodes['my-lib']], // version only my-lib
projectGraph,
specifier: '9.9.9', // user CLI specifier override set, no prompting should occur
currentVersionResolver: 'disk',
specifierSource: 'prompt',
releaseGroup: createReleaseGroup('independent'),
updateDependents: {
when: 'auto',
},
"name": "project-with-dependency-on-my-pkg",
"version": "0.0.1",
}
`);
expect(
readJson(
tree,
'libs/project-with-devDependency-on-my-pkg/package.json'
)
).toMatchInlineSnapshot(`
{
"devDependencies": {
"my-lib": "9.9.9",
});

expect(readJson(tree, 'libs/my-lib/package.json'))
.toMatchInlineSnapshot(`
{
"name": "my-lib",
"version": "9.9.9",
}
`);

expect(
readJson(
tree,
'libs/project-with-dependency-on-my-pkg/package.json'
)
).toMatchInlineSnapshot(`
{
"dependencies": {
"my-lib": "0.0.1",
},
"name": "project-with-dependency-on-my-pkg",
"version": "0.0.1",
}
`);
expect(
readJson(
tree,
'libs/project-with-devDependency-on-my-pkg/package.json'
)
).toMatchInlineSnapshot(`
{
"devDependencies": {
"my-lib": "0.0.1",
},
"name": "project-with-devDependency-on-my-pkg",
"version": "0.0.1",
}
`);
});

it(`should update dependents even when filtering to a subset of projects which do not include those dependents, if "when" is "always"`, async () => {
expect(readJson(tree, 'libs/my-lib/package.json').version).toEqual(
'0.0.1'
);
expect(
readJson(
tree,
'libs/project-with-dependency-on-my-pkg/package.json'
)
).toMatchInlineSnapshot(`
{
"dependencies": {
"my-lib": "0.0.1",
},
"name": "project-with-dependency-on-my-pkg",
"version": "0.0.1",
}
`);
expect(
readJson(
tree,
'libs/project-with-devDependency-on-my-pkg/package.json'
)
).toMatchInlineSnapshot(`
{
"devDependencies": {
"my-lib": "0.0.1",
},
"name": "project-with-devDependency-on-my-pkg",
"version": "0.0.1",
}
`);

await releaseVersionGenerator(tree, {
projects: [projectGraph.nodes['my-lib']], // version only my-lib
projectGraph,
specifier: '9.9.9', // user CLI specifier override set, no prompting should occur
currentVersionResolver: 'disk',
specifierSource: 'prompt',
releaseGroup: createReleaseGroup('independent'),
updateDependents: {
when: 'always',
},
"name": "project-with-devDependency-on-my-pkg",
"version": "0.0.1",
}
`);
});

expect(readJson(tree, 'libs/my-lib/package.json'))
.toMatchInlineSnapshot(`
{
"name": "my-lib",
"version": "9.9.9",
}
`);

expect(
readJson(
tree,
'libs/project-with-dependency-on-my-pkg/package.json'
)
).toMatchInlineSnapshot(`
{
"dependencies": {
"my-lib": "9.9.9",
},
"name": "project-with-dependency-on-my-pkg",
"version": "0.0.2",
}
`);
expect(
readJson(
tree,
'libs/project-with-devDependency-on-my-pkg/package.json'
)
).toMatchInlineSnapshot(`
{
"devDependencies": {
"my-lib": "9.9.9",
},
"name": "project-with-devDependency-on-my-pkg",
"version": "0.0.2",
}
`);
});
});
});
});
Expand Down Expand Up @@ -926,7 +1100,7 @@ To fix this you will either need to add a package.json file at that location, or
expect(outputSpy).toHaveBeenCalledWith({
title: `Invalid value for version.generatorOptions.versionPrefix: "$"

Valid values are: "auto", "", "~", "^"`,
Valid values are: "auto", "", "~", "^", "="`,
});

outputSpy.mockRestore();
Expand Down
Loading