-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(release): disable workspace changelogs in config when not valid #21341
fix(release): disable workspace changelogs in config when not valid #21341
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 864e991. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
workspaceChangelog
is enabled in the following cases when it isn't actually valid and won't be generated:Does not warn the user when both workspace and project level changelogs are disabled.
Expected Behavior
workspaceChangelog
is disabled in config in the above cases. This removes the need for the explicit workspaceChangelog override argument for the changelog command.Warn the user when both workspace and project level changelogs are disabled.