Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(release): default to 'patch' for --first-release with conventiona… #21491

Closed
wants to merge 2 commits into from
Closed

fix(release): default to 'patch' for --first-release with conventiona… #21491

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad2fcf4
fix(release): default to 'patch' for --first-release with conventiona…
nkalinov Feb 1, 2024
7755baa
Merge branch 'master' into fix/firstRelease-default-patch
JamesHenry May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/js/src/generators/release-version/release-version.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,13 @@ To fix this you will either need to add a package.json file at that location, or
options.conventionalCommitsConfig
);

// No changes detected.
// Pretty common for fresh repos created from a Web UI and where the first commits are usually something like "Initial commit".
// Make it a bit less confusing for such first releases by defaulting to patch.
if (!specifier && !latestMatchingGitTag && options.firstRelease) {
specifier = 'patch';
}

if (!specifier) {
log(
`🚫 No changes were detected using git history and the conventional commits standard.`
Expand Down