-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webpack): fix no such file or directory, open 'package-lock.json' #21835
Conversation
…, open 'package-lock.json' when adding `generatePackageJson: true` in webpack config nx js plugin try to read lock file from project directory and not workspace root. Closes nrwl#21651
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e949481. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
What’s the hold-up on this? I’m facing this issue as well and would like to see it fixed. |
Thank you for the fix @alonronin! |
Please excuse my impatience. When will the fix be available with |
@Bonscho it’s already available on next, which is currently 18.1.0-beta.4 18.1.1 will be released today or tomorrow most likely as well |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
when adding
generatePackageJson: true
in webpack config nx js plugin try to read lock file from project directory and not workspace root resulting in an error:HookWebpackError: ENOENT: no such file or directory, open 'package-lock.json'
Expected Behavior
should resolve from workspace root diretory.
Related Issue(s)
#21651
#21808
Fixes #21651 #21808