Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(webpack): surface original error when remotes fail to start #21919

Merged
merged 1 commit into from
Feb 21, 2024
Merged

fix(webpack): surface original error when remotes fail to start #21919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...s/angular/src/executors/module-federation-dev-server/module-federation-dev-server.impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,9 +192,12 @@ export async function* moduleFederationDevServerExecutor(
`NX All remotes started, server ready at http://localhost:${options.port}`
);
next({ success: true, baseUrl: `http://localhost:${options.port}` });
} catch {
} catch (err) {
throw new Error(
`Timed out waiting for remote to start. Check above for any errors.`
`Failed to start remotes. Check above for any errors.`,
{
cause: err,
}
);
} finally {
done();
Expand Down
7 changes: 5 additions & 2 deletions ...ges/react/src/executors/module-federation-dev-server/module-federation-dev-server.impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,9 +337,12 @@ export default async function* moduleFederationDevServer(

logger.info(`NX All remotes started, server ready at ${baseUrl}`);
next({ success: true, baseUrl: baseUrl });
} catch {
} catch (err) {
throw new Error(
`Timed out waiting for remote to start. Check above for any errors.`
`Failed to start remotes. Check above for any errors.`,
{
cause: err,
}
);
} finally {
done();
Expand Down