-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(graph): add error boundary error page for project details #22007
feat(graph): add error boundary error page for project details #22007
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 91416e2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
4375102
to
cc24ee8
Compare
132576f
to
5d4e7a0
Compare
5d4e7a0
to
ab8753c
Compare
ab8753c
to
a37874b
Compare
a37874b
to
f31934b
Compare
f31934b
to
be73e4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- small rewording
- we should take light / dark mode into consideration. Right now if you're in dark mode, the error page is rendered in light mode which is kind of jarring
Otherwise it looks good :)
be73e4a
to
6d644c6
Compare
6d644c6
to
1fa5533
Compare
1fa5533
to
ed7e121
Compare
ed7e121
to
0c304f4
Compare
0c304f4
to
f213d6e
Compare
f213d6e
to
91416e2
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
no error page for project details view when killed graph
Expected Behavior
Related Issue(s)
Fixes #