Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): experimental wasi target #22441

Closed
wants to merge 0 commits into from

Conversation

Brooooooklyn
Copy link
Contributor

@Brooooooklyn Brooooooklyn commented Mar 21, 2024

This pull request is trying to add wasm32-wasi target support for the nx/native

To test the build, you can run the following commands:

  • pnpm exec napi build --release --platform -c packages/nx/package.json --manifest-path packages/nx/Cargo.toml --js ./index.js -o packages/nx/src/native --target wasm32-wasi-preview1-threads

And the wasm file will be built at packages/nx/src/native/nx.wasm32-wasi.wasm

Blocked by:

The pseudo_terminal mod is excluded on the wasm32 targets, which is as expected.

The watch mod is excluded because of the upstream gix-* deps introduce by ignore-files don't support wasi target at this moment (but we can improve it).

Copy link

vercel bot commented Mar 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ❌ Failed (Inspect) Mar 21, 2024 4:52pm

@d3lm
Copy link

d3lm commented Mar 21, 2024

Thanks a ton @Brooooooklyn for this PR 🙏 🔥

@FrozenPandaz
Copy link
Collaborator

Oops I accidentally force pushed the wrong commit and the PR was closed. Unfortunately I can't reopen it.

I pushed the changes to a PR/branch on this repo: #22679

Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: core core nx functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants