fix(web): spa flag should correctly define redirect #22487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8c9c285. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Coly010
force-pushed
the
fix-file-server-spa
branch
from
68b1a1f
to
9c9f545
Compare
Coly010
force-pushed
the
fix-file-server-spa
branch
from
9c9f545
to
b805437
Compare
leosvelperez
requested changes
Mar 26, 2024
Coly010
force-pushed
the
fix-file-server-spa
branch
from
b805437
to
8c9c285
Compare
leosvelperez
approved these changes
Mar 26, 2024
jaysoo
approved these changes
Mar 26, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The
@nx/web:file-serverexecutor does not set upspahandling correctly. The current solution still causes the browser to throw a 404 which can cause unexpected behavior.Additionally, some of the packages that make use of the
@nx/web:file-serverwere not settingspaand thus deep linking would 404.Expected Behavior
The
spaflag on@nx/web:file-servershould correctly redirect to index.html and not throw 404s.The packages that need
spafrom@nx/web:file-servershould define it in their target, or via their inferred targets.Related Issue(s)
Fixes #22418
Despite having the
ciWebServerCommandset, theserve-statictarget needs to havespaworking correctly.