fix(testing): app generators should create correct e2e config at generation time #22565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 6c1a16e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Coly010
commented
Mar 28, 2024
| @@ -41,8 +45,34 @@ export async function normalizeOptions( | |||
| ? options.tags.split(',').map((s) => s.trim()) | |||
| : []; | |||
| const rootProject = appProjectRoot === '.'; | |||
|
|
|||
| let e2eWebServerTarget = 'serve'; | |||
There was a problem hiding this comment.
@xiongemi Could make sure some of the assumptions for expo projects are correct here?
- default
webServerTarget - default
portthe app gets served on
Coly010
commented
Mar 28, 2024
| @@ -44,8 +48,35 @@ export async function normalizeOptions( | |||
| const iosProjectRoot = joinPathFragments(appProjectRoot, 'ios'); | |||
| const androidProjectRoot = joinPathFragments(appProjectRoot, 'android'); | |||
| const rootProject = appProjectRoot === '.'; | |||
|
|
|||
| let e2eWebServerTarget = 'start'; | |||
There was a problem hiding this comment.
@xiongemi Could make sure some of the assumptions for react-native projects are correct here?
- default
webServerTarget - default
portthe app gets served on
xiongemi
approved these changes
Apr 2, 2024
leosvelperez
approved these changes
Apr 3, 2024
ndcunningham
approved these changes
Apr 3, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The current e2e app generation for various app generators has the chance of producing invalid config files due to some edge cases around Nx Crystal.
Expected Behavior
Ensure e2e app generation creates correct config
Related Issue(s)
Fixes #