Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): list crystal plugins with nx report #22649

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Apr 3, 2024

Current Behavior

When running Nx Report we have no way to tell if users are using Crystal plugins or not.
When dealing with GH Issues, this makes it more difficult to discern if problems are executor related or crystal plugin related.

Expected Behavior

We should list the Crystal plugins that are being used in the Nx Workspace when nx report is run.
This will not completely alleviate the issues with knowing whether executors are being used or not, but it will help at least.

Related Issue(s)

Fixes #

@Coly010 Coly010 requested a review from a team as a code owner April 3, 2024 10:49
@Coly010 Coly010 self-assigned this Apr 3, 2024
Copy link

vercel bot commented Apr 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Apr 5, 2024 2:04pm

packages/nx/src/command-line/report/report.ts Outdated Show resolved Hide resolved
packages/nx/src/command-line/report/report.ts Outdated Show resolved Hide resolved
@FrozenPandaz
Copy link
Collaborator

Can you please show the before and after of the terminal output?

@Coly010
Copy link
Contributor Author

Coly010 commented Apr 5, 2024

Before
image

After
image

@Coly010 Coly010 enabled auto-merge (squash) April 5, 2024 15:52
@Coly010 Coly010 merged commit 1239325 into nrwl:master Apr 5, 2024
6 checks passed
@Coly010 Coly010 deleted the update-nx-report branch April 5, 2024 16:18
FrozenPandaz pushed a commit that referenced this pull request Apr 5, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants