Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module-federation): serve dynamic remotes statically in their own processes #22688

Merged
merged 2 commits into from Apr 5, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Apr 5, 2024

  • fix(angular): serve dynamic remotes statically in their own processes
  • fix(react): serve dynamic remotes statically in their own processes

Current Behavior

Dynamic Remotes are not served correctly or at all leading to failures or forcing users to serve the dynamic remotes indvidually on their own.

Expected Behavior

Serve the dynamic remotes for the user

Related Issue(s)

Fixes #21901

@Coly010 Coly010 requested review from jaysoo and a team as code owners April 5, 2024 10:40
@Coly010 Coly010 self-assigned this Apr 5, 2024
Copy link

vercel bot commented Apr 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Apr 5, 2024 10:46am

@Coly010 Coly010 enabled auto-merge (squash) April 5, 2024 15:46
@Coly010 Coly010 merged commit 640c61d into nrwl:master Apr 5, 2024
6 checks passed
@Coly010 Coly010 deleted the mf/serve-dynamic-remotes-individually branch April 5, 2024 16:19
FrozenPandaz pushed a commit that referenced this pull request Apr 5, 2024
@kevinriemens
Copy link

kevinriemens commented Apr 7, 2024

Installed 18.2.3, issue still remains unfortunately. Switching back to devRemotes in the configuration again, because serving static remotes still messes up the routing/guards of one of our remotes.

Next to that, the static remotes only build the first time you run nx serve. As soon as you run nx serve a second time (without changes to the source code in the remotes), it hangs on 'building static remotes` indefinitely.

Running Angular with MFE and SSR.

Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic module federation doesn't work with proposed remote app manifest file
4 participants