Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): remove url-loader from dependencies since it is replaced by asset modules #22698

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Apr 5, 2024

We have already replaced url-loader with Webpack 5's asset modules, this clean-up was previously missed. We'll remove file-loader in Nx 20, since removing it now results in a breaking change for SVGR users.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@jaysoo jaysoo requested review from a team as code owners April 5, 2024 17:11
@jaysoo jaysoo requested a review from ndcunningham April 5, 2024 17:11
Copy link

vercel bot commented Apr 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Apr 5, 2024 5:12pm

@jaysoo jaysoo enabled auto-merge (squash) April 5, 2024 17:48
@jaysoo jaysoo merged commit 900db73 into master Apr 5, 2024
6 checks passed
@jaysoo jaysoo deleted the remove_url_loader branch April 5, 2024 17:49
FrozenPandaz pushed a commit that referenced this pull request Apr 5, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants