Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundling): support exported array of options for rollup #22703

Merged
merged 1 commit into from Apr 5, 2024

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Apr 5, 2024

This PR allows users to export an array of rollup options in rollup.config.js.

The e2e test shows an example:

module.exports = (config) => [{
...config,
output: {
  format: "esm",
  dir: "dist/test",
  name: "Mylib",
  entryFileNames: "[name].js",
  chunkFileNames: "[name].js"
}
}];

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #16567

@jaysoo jaysoo requested a review from a team as a code owner April 5, 2024 19:15
@jaysoo jaysoo requested a review from Coly010 April 5, 2024 19:15
Copy link

vercel bot commented Apr 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Apr 5, 2024 7:15pm

@jaysoo jaysoo merged commit 430aecc into master Apr 5, 2024
6 checks passed
@jaysoo jaysoo deleted the issue_16567 branch April 5, 2024 19:45
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nrwl/rollup: Build fails with multiple build configs via array syntax in rollup.config.js
3 participants