Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): propagate error from child process to @nx/js:node executor #22705

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Apr 5, 2024

This PR allows @nx/js:node executor to exit with an error code rather than marking the run as successful. This change will mark the task as a failure rather than success.

Notes:

  • If watch: true, then we already log out the exit code, and users can update code to restart the process.
  • If watch: false, then the exit code will be 1 and we log out the error code from the child process as well.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@jaysoo jaysoo requested a review from a team as a code owner April 5, 2024 20:02
@jaysoo jaysoo requested a review from mandarini April 5, 2024 20:02
Copy link

vercel bot commented Apr 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Apr 5, 2024 9:30pm

@jaysoo jaysoo enabled auto-merge (squash) April 5, 2024 20:26
@jaysoo jaysoo merged commit a9e554f into master Apr 5, 2024
6 checks passed
@jaysoo jaysoo deleted the issue_9239 branch April 5, 2024 21:45
FrozenPandaz pushed a commit that referenced this pull request Apr 5, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants