-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"nx migrate" mangles binary files #22788
Comments
Would you like to submit a PR? The changes should be done here: https://github.com/nrwl/nx/blob/master/packages/devkit/src/utils/binary-extensions.ts |
I'm happy to submit additions to the extension list, but I'd much prefer the logic be fully inverted, and nx only act on file extensions on an allowlist vs the current "list of files to leave alone"- for instance, we have binaries checked in without extensions. |
Hey @potch! I'm going to go ahead and close this out with the added binary extensions being merged. Most migrations shouldn't hit every arbitrary file, so this was likely a one-time fix and we will re-evaluate if we need to do a similar mass update in the future. |
Current Behavior
When running
nx migrate
and applying migrations, the migration scripts changed hundreds of binary files across our monorepo, corrupting themExpected Behavior
nx migrate
operates on anallowList
principle, and does not modify files it does not understand.GitHub Repo
No response
Steps to Reproduce
nx@15
repository containing binary files: extensions include.als
,.pkg
,.npy
,.plist
nx migrate latest
, and apply recommended migrationsNx Report
Failure Logs
No response
Package Manager Version
No response
Operating System
Additional Information
happy to provide before/after examples of binary files if needed.
The text was updated successfully, but these errors were encountered: