feat(nx-dev): Use app router for blogs #23127
Open
+577
−470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0b28a95. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
ndcunningham
force-pushed
the
feat/nx-dev-blog-app-router
branch
from
c47d979
to
b36628c
Compare
ndcunningham
force-pushed
the
feat/nx-dev-blog-app-router
branch
from
b36628c
to
c8cb44b
Compare
ndcunningham
force-pushed
the
feat/nx-dev-blog-app-router
branch
from
c8cb44b
to
1a2f64c
Compare
ndcunningham
added
the
PR status: do not merge
ndcunningham
force-pushed
the
feat/nx-dev-blog-app-router
branch
2 times, most recently
from
61f7fc8
to
8eac49e
Compare
ndcunningham
force-pushed
the
feat/nx-dev-blog-app-router
branch
2 times, most recently
from
9beb274
to
35f61ff
Compare
ndcunningham
removed
the
PR status: do not merge
ndcunningham
force-pushed
the
feat/nx-dev-blog-app-router
branch
from
35f61ff
to
a6b6ff3
Compare
ndcunningham
changed the title
ndcunningham
requested review from
a team,
philipjfulcher,
FrozenPandaz,
bcabanes,
MaxKless and
xiongemi
as code owners
ndcunningham
force-pushed
the
feat/nx-dev-blog-app-router
branch
from
a6b6ff3
to
422f9cd
Compare
ndcunningham
force-pushed
the
feat/nx-dev-blog-app-router
branch
from
422f9cd
to
3d9255f
Compare
ndcunningham
changed the title
ndcunningham
force-pushed
the
feat/nx-dev-blog-app-router
branch
from
3d9255f
to
9dc6409
Compare
jaysoo
reviewed
May 31, 2024
| @@ -1,3 +1,4 @@ | |||
| 'use client'; | |||
There was a problem hiding this comment.
Follow-up: Move use client lower where possible.
jaysoo
reviewed
May 31, 2024
feat(nx-dev): updated layout file segregating client and server side features Fixed initial loaded so that theme is loaded without delay tsconfig.json has been "fixed" for nx-dev initially we thought it was using tsconfig.app.json
ndcunningham
force-pushed
the
feat/nx-dev-blog-app-router
branch
from
9dc6409
to
0b28a95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR activates the app router for the Blog page at /blog.
Its purpose is to test Next.js changes within nx-dev, allowing us to identify and address any issues that users might encounter.
Integrating these changes into our environment, we can gain firsthand experience and insights into potential problems, ensuring that the updates are robust and reliable.
This approach helps us improve the overall quality and user experience of our platform by proactively identifying and resolving any issues that could affect consumers.