fix(release): update regex for remote URL

[pcopley]

Updates remote URL regex to match on GitHub, GitHub Enterprise, and local git repositories.

Current Behavior

Currently the regular expression will only match URLs beginning with github.com

Expected Behavior

It should also match GitHub Enterprise as well as local git repositories

Related Issue(s)

Fixes #23178
Closes #21906

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated (UTC)
nx-dev	⬜️ Ignored (Inspect)	Visit Preview	May 4, 2024 1:16pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 03110ea. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

🟥 Failed Commands
nx-cloud record -- nx format:check --base=fd5ea92062eba93336f2b56cf0960ada67ac830e --head=03110ead12699e0e122493b341fc4a3570636e9f
nx run e2e-workspace-create:e2e
nx run e2e-web:e2e
nx run e2e-react-core:e2e
nx run e2e-webpack:e2e
nx run e2e-vite:e2e
nx run e2e-react-extensions:e2e
nx run e2e-vue:e2e

|

⤵️ And 19 more

- nx run e2e-nx-misc:e2e
- nx run e2e-storybook:e2e
- nx run e2e-remix:e2e
- nx run e2e-release:e2e
- nx run e2e-rollup:e2e
- nx run e2e-nx-run:e2e
- nx run e2e-next-extensions:e2e
- nx run e2e-next-core:e2e
- nx run e2e-eslint:e2e
- nx run e2e-playwright:e2e
- nx run e2e-nx-init:e2e
- nx run e2e-plugin:e2e
- nx run e2e-js:e2e
- nx run e2e-node:e2e
- nx run e2e-react-module-federation:e2e
- nx run e2e-cypress:e2e
- nx run e2e-jest:e2e
- nx run e2e-nuxt:e2e
- nx run e2e-esbuild:e2e

|

✅ Successfully ran 7 targets

• nx documentation --no-dte
• nx affected -t e2e-macos-ci --parallel=1 --base=fd5ea92062eba93336f2b56cf0960ada67ac830e --head=03110ead12699e0e122493b341fc4a3570636e9f
• nx run e2e-workspace-create-npm:e2e
• nx run e2e-storybook-angular:e2e
• nx run e2e-angular-core:e2e
• nx run e2e-angular-extensions:e2e
• nx run e2e-lerna-smoke-tests:e2e

---

Sent with 💌 from NxCloud.

[andrewlewis426]

@JamesHenry We need this in our organization as we use github enterprise. What can we do to move this pr forward?

[JamesHenry]

@andrewlewis426 You could please apply this change as a patch to your node_modules (eg. via https://www.npmjs.com/package/patch-package or via pnpm patches if you use pnpm) and verify that it is all that is needed for holistic support of github enterprise

[Bare1337]

@pcopley @JamesHenry Thanks for the great work put in. Nevertheless, as we experienced some issues trying to use nx release with GES i don't think this PR could close #21906 by itself.

This is a list of the issues we've been through:

• on logTitle assignation, github.com is hardcoded which does not affect anything but lead to misinformation.
  

  nx/packages/nx/src/command-line/release/utils/github.ts

  Line 109 in 7088b09

  const logTitle = `https://github.com/${githubRepoSlug}/releases/tag/${releaseVersion.gitTag}`;

• baseUrl passed to axios request options in the method makeGithubRequest is hardcoded as 'https://api.github.com' which is not the correct url with GES (http(s)://HOSTNAME/api/v3)
  

  nx/packages/nx/src/command-line/release/utils/github.ts

  Line 362 in 7088b09

  baseURL: 'https://api.github.com',

• github.com is hardcoded as hostname in the method githubNewReleaseURL
  

  nx/packages/nx/src/command-line/release/utils/github.ts

  Line 400 in 7088b09

  return `https://github.com/${config.repo}/releases/new?tag=${

• github.com is hardcoded as hostname in the method formatReference
  

  nx/packages/nx/src/command-line/release/utils/github.ts

  Line 416 in 7088b09

  return `[${ref.value}](https://github.com/${repoSlug}/${

We're not using github CLI but there might be some issues with the method resolveGithubToken too, not sure about that.

After patching thoses issues locally, it's working great.
Maybe we could offer an opportunity to set up the hostname and base API url directly from nx.json

@JamesHenry I'am not sure if it should be treated separately but i could open another issue and i'am willing to submit a PR if necessary.

Again, thanks for the great work tho, awesome tool.