fix(core): not load env files when NX_LOAD_DOT_ENV_FILES is false #23231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 6b6006a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
leosvelperez
approved these changes
May 8, 2024
|
Tested it locally using the repro from #23090. It is working. |
jaysoo
approved these changes
May 8, 2024
xiongemi
force-pushed
the
feature/nxc-646-support-nx_load_dot_env_files-to-disable-loading-dotenv
branch
from
befaabd
to
2861f9c
Compare
FrozenPandaz
requested changes
May 8, 2024
| @@ -27,7 +27,10 @@ export async function runOne( | |||
| string, | |||
| (TargetDependencyConfig | string)[] | |||
| > = {}, | |||
| extraOptions = { excludeTaskDependencies: false, loadDotEnvFiles: true } as { | |||
| extraOptions = { | |||
There was a problem hiding this comment.
Can you also update run-many and affected please?
xiongemi
force-pushed
the
feature/nxc-646-support-nx_load_dot_env_files-to-disable-loading-dotenv
branch
from
2861f9c
to
c195d63
Compare
xiongemi
force-pushed
the
feature/nxc-646-support-nx_load_dot_env_files-to-disable-loading-dotenv
branch
from
c195d63
to
c76f04a
Compare
xiongemi
force-pushed
the
feature/nxc-646-support-nx_load_dot_env_files-to-disable-loading-dotenv
branch
from
c76f04a
to
1ec7d97
Compare
xiongemi
force-pushed
the
feature/nxc-646-support-nx_load_dot_env_files-to-disable-loading-dotenv
branch
from
1ec7d97
to
de15de8
Compare
xiongemi
force-pushed
the
feature/nxc-646-support-nx_load_dot_env_files-to-disable-loading-dotenv
branch
from
de15de8
to
bb1d433
Compare
xiongemi
force-pushed
the
feature/nxc-646-support-nx_load_dot_env_files-to-disable-loading-dotenv
branch
from
bb1d433
to
6b6006a
Compare
FrozenPandaz
approved these changes
May 14, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
May 14, 2024
…3231) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #23090 (cherry picked from commit 9122b85)
Coly010
pushed a commit
that referenced
this pull request
May 15, 2024
…3231) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #23090
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #23090