-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(devkit): combineAsyncIterable should not be blocking when error occurs #21393 #23400
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7c7e109. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
8d21565
to
fa383b2
Compare
packages/devkit/src/utils/async-iterable/combine-async-iterables.spec.ts
Outdated
Show resolved
Hide resolved
fa383b2
to
7c7e109
Compare
…ccurs #21393 (#23400) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior <!-- This is the behavior we have today --> `combineAsyncIterators` has a `finally` block which is blocking execution waiting for all iterators to be `done` so it can call the `return` function as cleanup. This leads to prolonged execution when unnecessary, such as when an error has occurred. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> `finally` block should be non-blocking allowing errors to be immediately surfaced and execution to stop. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #21393 (cherry picked from commit 4442945)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
combineAsyncIterators
has afinally
block which is blocking execution waiting for all iterators to bedone
so it can call thereturn
function as cleanup.This leads to prolonged execution when unnecessary, such as when an error has occurred.
Expected Behavior
finally
block should be non-blocking allowing errors to be immediately surfaced and execution to stop.Related Issue(s)
Fixes #21393