Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): fix module resolution in project locator #2941

Merged
merged 1 commit into from
May 24, 2020
Merged

fix(core): fix module resolution in project locator #2941

merged 1 commit into from
May 24, 2020

Commits on Apr 30, 2020

  1. fix(core): fix module resolution in project locator 

    On windows, there is a bug in project module resolution, cause by path separator.  TypeScript resolveModuleName will always return a posix normalized path, so our appRootPath needs to be normalized for string replacement.

I came across the issue when trying to run dep-graph, but other areas (ex: affected:*) which rely on TargetProjectLocator are going to be impacted.
    @rhutchison
    rhutchison committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    fe9ee3e View commit details
    Browse the repository at this point in the history