fix(storybook): allow variables in NgModule declarations #4318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI ran the following commands for commit 9267aef. Click to see the status, the terminal output, and the build insights.
Sent with 💌 from NxCloud. |
allout58
force-pushed
the
fix-storybook-variable-declaration
branch
from
7d0486d
to
9267aef
Compare
FrozenPandaz
approved these changes
Dec 17, 2020
|
LGTM! 🎉 Good work! |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUES CLOSED: #4314
Current Behavior
Declaring components through a variable in the
module.tsfile used to generate stories will block any stores fromExpected Behavior
Follow the variable to discover components, or fail with a meaningful error message.
Related Issue(s)
Fixes #4314