fix(angular): honor buildableProjectDepsInPackageJsonType in angula…
#4760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mhodgson can you do a push again, e.g. rebase with master and force push again or something else to trigger the pipeline. It got stuck for some weird reason. |
|
@juristr not really... I don't have access to check out the repo right now. I did the edit and PR right in Github's UI. |
juristr
force-pushed
the
patch-3
branch
2 times, most recently
from
90febbd
to
5927002
Compare
Nx Cloud ReportCI ran the following commands for commit fe14f6e. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
…r:package builder Fixes the angular:package builder to honor the `buildableProjectDepsInPackageJsonType` setting. It was previously ignored.
This was referenced Mar 11, 2021
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option is said to be available, but it is not actually used. This commit properly utilizes the option.
Current Behavior
The
buildableProjectDepsInPackageJsonTypeis ignored in the @nrwl/angular:package builder. Setting it to the non-defaultpeerDependencieshas no effect.Expected Behavior
The
buildableProjectDepsInPackageJsonTypeshould be honored in the @nrwl/angular:package builder. Setting it to the non-defaultpeerDependenciesshould add buildable dependencies to thepeerDependenciesof thepackage.jsonfile for the packaged library.Related Issue(s)
None found