feat(linter): warn on react-hooks/exhaustive-deps rule
#5105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI ran the following commands for commit dcd9037. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
MichaelDeBoey
changed the title
react-hooks/exhaustive-deps rulereact-hooks/exhaustive-deps rule
FrozenPandaz
requested changes
Mar 26, 2021
| @@ -63,6 +63,7 @@ export default { | |||
| * React Hooks rule configurations | |||
| * https://github.com/facebook/react/tree/master/packages/eslint-plugin-react-hooks | |||
| */ | |||
| 'react-hooks/exhaustive-deps': 'warn', | |||
There was a problem hiding this comment.
Hm this is already set to warn in the react-base config. However, it's overwritten in react-typescript 🤔
That doesn't seem right to me... In fact, I think we should extend the facebook config.
Can you remove hooks rules from here as well as react-typescript and react-base then add extends: ["plugin:react-hooks/recommended"] to react-base?
|
Closing in favor of #5258 |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's recommended: https://github.com/facebook/react/blob/fb8c1917e9985f83032f642e5db8b9abf089653e/packages/eslint-plugin-react-hooks/src/index.js#L14-L20