Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(misc): update READMEs to have alt on <img> tags #5306

Merged
merged 1 commit into from
Apr 22, 2021
Merged

docs(misc): update READMEs to have alt on <img> tags #5306

merged 1 commit into from
Apr 22, 2021

Conversation

vivekmore
Copy link
Contributor

Current Behavior

  • generated code contains img tags without alt attribute
  • docs have img tags without alt attribute

Expected Behavior

  • generated code contains img tags with alt attribute
  • docs have img tags with alt attribute

@nx-cloud
Copy link

nx-cloud bot commented Apr 10, 2021 •
edited

Nx Cloud Report

CI ran the following commands for commit 4f0a2a6. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=build --all
#000000 nx run-many --target=e2e --projects=e2e-angular
#000000 nx run-many --target=e2e --projects=e2e-cypress,e2e-jest
#000000 nx run-many --target=e2e --projects=e2e-next,e2e-gatsby
#000000 nx run-many --target=e2e --projects=e2e-node
#000000 nx run-many --target=e2e --projects=e2e-nx-plugin
#000000 nx run-many --target=e2e --projects=e2e-react
#000000 nx run-many --target=e2e --projects=e2e-web,e2e-linter,e2e-storybook
#000000 nx run-many --target=e2e --projects=e2e-workspace
#000000 nx run-many --target=lint --all --parallel
#000000 nx run-many --target=test --all --parallel

Sent with 💌 from NxCloud.

@vivekmore vivekmore marked this pull request as ready for review April 10, 2021 20:31
juristr
juristr requested changes Apr 12, 2021
View reviewed changes
Copy link
Member

@juristr juristr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Just a couple of comments. If we add alt tags, we should make sure to describe the content of the image/link.

If you can make these changes I'm happy to merge it

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
packages/next/README.md Outdated Show resolved Hide resolved
packages/react/README.md Outdated Show resolved Hide resolved
scripts/readme-fragments/resources.md Outdated Show resolved Hide resolved
scripts/readme-fragments/resources.md Outdated Show resolved Hide resolved
scripts/readme-fragments/resources.md Outdated Show resolved Hide resolved
@vivekmore vivekmore force-pushed the feature/use-more-es6-features branch from 02a45c9 to 139e498 Compare April 12, 2021 11:57
@vivekmore
Copy link
Contributor Author

updated all descriptions as suggested

@vivekmore vivekmore force-pushed the feature/use-more-es6-features branch 2 times, most recently from 966f694 to ac1bd3d Compare April 21, 2021 02:01
@juristr juristr force-pushed the feature/use-more-es6-features branch from ac1bd3d to 4f0a2a6 Compare April 22, 2021 13:30
@juristr juristr changed the title cleanup(angular): update generated code to have alt on <img> tags docs(misc): update READMEs to have alt on <img> tags Apr 22, 2021
@juristr juristr enabled auto-merge (squash) April 22, 2021 13:32
@juristr juristr merged commit 4a53453 into nrwl:master Apr 22, 2021
@vivekmore vivekmore deleted the feature/use-more-es6-features branch April 22, 2021 16:29
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@juristr juristr juristr requested changes

Assignees

@juristr juristr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vivekmore @juristr