feat(devkit): make nx.json optional #6398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/F9AvDqMi7xTD8pack4jj9qis32t7 |
edbzn
changed the title
ignoreNxJson optionignoreNxJson option
edbzn
force-pushed
the
devkit-ignore-nx-json
branch
from
04e3d39
to
b4196c5
Compare
Nx Cloud ReportCI is running for commit 4110ae5. 📂 Click to track the progress, see the status, the terminal output, and the build insights. Sent with 💌 from NxCloud. |
edbzn
force-pushed
the
devkit-ignore-nx-json
branch
from
b4196c5
to
e2fdcae
Compare
FrozenPandaz
requested changes
Jul 20, 2021
Allow project configuration functions to work without nx.json configuration file, this is particulary handy for regular Angular CLI projects.
edbzn
force-pushed
the
devkit-ignore-nx-json
branch
from
e2fdcae
to
7f9151b
Compare
edbzn
changed the title
ignoreNxJson option
FrozenPandaz
approved these changes
Jul 29, 2021
FrozenPandaz
added a commit
that referenced
this pull request
Jul 29, 2021
* feat(devkit): make nx.json optional (#5678) Allow project configuration functions to work without nx.json configuration file, this is particulary handy for regular Angular CLI projects. * docs(devkit): make `NxJsonConfiguration` partial Co-authored-by: Jason Jean <jasonjean1993@gmail.com>
ManojBahuguna
pushed a commit
to ManojBahuguna/nx
that referenced
this pull request
Sep 16, 2021
* feat(devkit): make nx.json optional (nrwl#5678) Allow project configuration functions to work without nx.json configuration file, this is particulary handy for regular Angular CLI projects. * docs(devkit): make `NxJsonConfiguration` partial Co-authored-by: Jason Jean <jasonjean1993@gmail.com>
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Devkit project configuration functions require
nx.jsonfile to be present on the workspace by reading it from the Tree. This breaks the compatibility with regular Angular CLI projects.Expected Behavior
Optionally read nx.json file from the Tree, this is particularly useful for using the devkit to create schematics and builders for regular Angular CLI projects.
Related Issue(s)
Fixes #5678