Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): make it possible to use environment variable to set cache… #6670

Merged
merged 1 commit into from Aug 11, 2021
Merged

feat(core): make it possible to use environment variable to set cache… #6670

merged 1 commit into from Aug 11, 2021

Conversation

shihabuddin
Copy link
Contributor

@shihabuddin shihabuddin commented Aug 10, 2021 •
edited

… directory

Use the environment variable NX_CACHE_DIRECTORY to set the cache directory.
This would override the cache directory set in nx.json.

ISSUES CLOSED: #6629

Current Behavior

The cache directory can only be set using nx.json.

Expected Behavior

The cache directory set in nx.json can be overwritten using environment variable NX_CACHE_DIRECTORY.

Related Issue(s)

Fixes #6629

@shihabuddin
feat(core): make it possible to use environment variable to set cache…
6c16ee0 
… directory

Use the environment variable NX_CACHE_DIRECTORY to set the cache directory.
This would override the cache directory set in nx.json.

ISSUES CLOSED: nrwl#6629
@vercel
Copy link

vercel bot commented Aug 10, 2021 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/8i35eDi8iggdZ5ougv9q9aY4jqwG
✅ Preview: Canceled

@nx-cloud
Copy link

nx-cloud bot commented Aug 10, 2021

Nx Cloud Report

CI ran the following commands for commit 6c16ee0. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx affected --target=e2e --base=549b735057edb78f55ffc1a881c0f1119579154d
#000000 nx affected --target=lint --base=549b735057edb78f55ffc1a881c0f1119579154d --parallel --max-parallel=4
#000000 nx affected --target=test --base=549b735057edb78f55ffc1a881c0f1119579154d --parallel --max-parallel=2
#000000 nx affected --target=build --base=549b735057edb78f55ffc1a881c0f1119579154d --parallel --max-parallel=3
#000000 nx build typedoc-theme

Sent with 💌 from NxCloud.

FrozenPandaz
FrozenPandaz approved these changes Aug 11, 2021
View reviewed changes
Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you so much for contributing! LGTM 🎉

@FrozenPandaz FrozenPandaz merged commit 8cad038 into nrwl:master Aug 11, 2021
ManojBahuguna pushed a commit to ManojBahuguna/nx that referenced this pull request Sep 16, 2021
@shihabuddin @ManojBahuguna
feat(core): make it possible to use environment variable to set cache…
e953394 
… directory (nrwl#6670)

Use the environment variable NX_CACHE_DIRECTORY to set the cache directory.
This would override the cache directory set in nx.json.

ISSUES CLOSED: nrwl#6629
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FrozenPandaz FrozenPandaz FrozenPandaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

environment variable to override cacheDirectory in nx.json
2 participants
@shihabuddin @FrozenPandaz