Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): fix stylesOptimization for webpack 5 #6817

Merged
merged 1 commit into from Sep 15, 2021
Merged

fix(web): fix stylesOptimization for webpack 5 #6817

merged 1 commit into from Sep 15, 2021

Conversation

markogresak
Copy link
Contributor

@markogresak markogresak commented Aug 23, 2021

Current Behavior

The output CSS is not minified when running the production build with webpack 5.

Expected Behavior

The CSS is minified when using --prod build flag or NODE_ENV=production.

Related Issue(s)

Fixes #6816

@vercel
Copy link

vercel bot commented Aug 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/4ZLGbN8KQzkGHY3irFVMwet2bKxE
✅ Preview: Canceled

[Deployment for d84f82c canceled]

@markogresak
Copy link
Contributor Author

It's been 10h and the build status is still not updated, why is that?

@jaysoo
Copy link
Member

jaysoo commented Sep 15, 2021

Thank for the MR. I'll try a force update to restart CI.

@jaysoo jaysoo enabled auto-merge (squash) September 15, 2021 14:35
@jaysoo jaysoo merged commit bbeb89c into nrwl:master Sep 15, 2021
@jaysoo
Copy link
Member

jaysoo commented Sep 15, 2021

merged! thanks again

ManojBahuguna pushed a commit to ManojBahuguna/nx that referenced this pull request Sep 16, 2021
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Styles optimization is not applied when using Webpack 5
2 participants