Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): ensure export works with nextjs v11.1 #6900

Closed
wants to merge 1 commit into from

Conversation

JamesHenry
Copy link
Collaborator

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Aug 31, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/HMiBNLpc5KiwvR7EUkn78ZFx9Tq1
✅ Preview: Canceled

@JamesHenry
Copy link
Collaborator Author

FYI I didn't find this through usage, it is blocking PRs from passing CI

@JamesHenry JamesHenry added scope: nextjs Issues related to NextJS support for Nx type: bug labels Aug 31, 2021
@JamesHenry
Copy link
Collaborator Author

JamesHenry commented Aug 31, 2021

Oh boy... This passes for me locally with this change when it failed locally before the change (both isolating the failing test and running the full next e2e) but still fails in CI:

image

@JamesHenry
Copy link
Collaborator Author

The only difference I can see between CI and my machine (other than OS) is the use of pnpm...

@JamesHenry
Copy link
Collaborator Author

Trying a rerun just in case

@JamesHenry
Copy link
Collaborator Author

We think #6903 is actually more likely to be the CI fix, so closing this for now

@JamesHenry JamesHenry closed this Aug 31, 2021
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: nextjs Issues related to NextJS support for Nx type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant