Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): incremental builds with mfes #6923 #7260

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Oct 6, 2021

Current Behavior

Cannot share buildable libraries between host and remote mfe apps

Expected Behavior

Buildable libraries should be shareable between host and remote mfe apps

Related Issue(s)

Fixes #6923

@Coly010 Coly010 self-assigned this Oct 6, 2021
@vercel
Copy link

vercel bot commented Oct 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/9zbXsrqXJ1jawxUEQ2bWAvRp84EB
✅ Preview: Canceled

[Deployment for 49946d8 canceled]

Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@Coly010 Coly010 merged commit 654cfbf into nrwl:master Oct 6, 2021
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module fedaration with shared libs and building
2 participants