Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): handle different workspace format version when falling back to the angular cli #8993

Merged
merged 1 commit into from Feb 16, 2022

Conversation

leosvelperez
Copy link
Member

Current Behavior

Expected Behavior

When a command that's unknown to the Nx CLI is used in an Angular workspace, the Nx CLI falls back to the Angular CLI to run the command. If this is done in a workspace with a different workspace configuration format version, it fails with an error stating that the workspace format version is invalid.

Related Issue(s)

When falling back to the Angular CLI, it should be able to read the workspace config regardless of the format version.

Fixes #

@leosvelperez leosvelperez self-assigned this Feb 16, 2022
@vercel
Copy link

vercel bot commented Feb 16, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/7NgZw8NBZTmcd1jWpAezi11qzpgj
✅ Preview: Canceled

@vsavkin vsavkin merged commit 1cae869 into nrwl:master Feb 16, 2022
@leosvelperez leosvelperez deleted the core/fix-ng-cli-fallback branch February 21, 2022 11:17
meeroslav pushed a commit to meeroslav/nx that referenced this pull request Mar 4, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants