Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storybook): should add @storybook/react-native to devDependencies #9364

Merged
merged 1 commit into from Mar 17, 2022
Merged

fix(storybook): should add @storybook/react-native to devDependencies #9364

merged 1 commit into from Mar 17, 2022

Conversation

xiongemi
Copy link
Collaborator

@xiongemi xiongemi commented Mar 16, 2022 •
edited

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #9336

@xiongemi xiongemi requested a review from mandarini March 16, 2022 17:01
@mandarini mandarini enabled auto-merge (squash) March 16, 2022 17:13
@xiongemi xiongemi changed the title bugfix(storybook): should add @storybook/react-native to devDependencies fix(storybook): should add @storybook/react-native to devDependencies Mar 16, 2022
@nx-cloud
Copy link

nx-cloud bot commented Mar 16, 2022 •
edited

☁️ Nx Cloud Report

CI ran the following commands for commit 4266cfd. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 11 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Mar 16, 2022 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/DfdYbM2sSvMy6GPoLzx8c1S9mYtQ
✅ Preview: Canceled

[Deployment for 4266cfd canceled]

@xiongemi xiongemi force-pushed the bugfix/react-native-storybook-devDependencies branch from d07e717 to e44ec3a Compare March 16, 2022 21:56
@xiongemi xiongemi force-pushed the bugfix/react-native-storybook-devDependencies branch from e44ec3a to 4266cfd Compare March 17, 2022 00:10
@mandarini mandarini merged commit 83acbaf into master Mar 17, 2022
FrozenPandaz pushed a commit that referenced this pull request Mar 21, 2022
@xiongemi @FrozenPandaz
bugfix(storybook): should add @storybook/react-native to devDependenc…
ae40364 
…ies (#9364)
@FrozenPandaz FrozenPandaz deleted the bugfix/react-native-storybook-devDependencies branch June 7, 2022 23:32
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mandarini mandarini mandarini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Storybook Issue with react-native
2 participants
@xiongemi @mandarini