feat(storybook): use build-storybook as a build target for all libs #9651
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Our
storybook-configuration
executor would look for build targets in Angular projects, and if it found@nrwl/angular:ng-packagr-lite
and@angular-devkit/build-angular:browser
as executors, it would know it's looking at a build target, and it would specify theprojectBuildConfig
of that project for Storybook to use that build target.However,
ng-packagr-lite
does not support more options about styles and stylePreprocessor options, so users who wanted to specify these, they would manually go and change theprojectBuildConfig
in their buildable Angular libs, for Storybook. Since that was the case for a few issues on GitHub, I think it is better to only point to the project's build target when@angular-devkit/build-angular:browser
is used, and in all other cases point directly tobuild-storybook
.Expected Behavior
Only point to the project's build target when
@angular-devkit/build-angular:browser
is used, and in all other cases point directly tobuild-storybook
.