New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storybook): add projectBuildConfig as an option in generator #9655
feat(storybook): add projectBuildConfig as an option in generator #9655
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/HUnXsZZuLCe1gyDKKaQNCkB7PC1f |
2870f9d
to
d4f46cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
I left a small nitpick, feel free to ignore it if you like 😄
75bf7a1
to
f3f4d6f
Compare
f3f4d6f
to
519b40e
Compare
519b40e
to
ceaf712
Compare
Co-authored-by: Colum Ferry <cferry09@gmail.com>
ceaf712
to
9a92696
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
projectBuildConfig
is set automatically when generating storybook configurationExpected Behavior
While setting the
projectBuildConfig
automatically is good for almost all cases, there are some niche cases where a user would want to specify a custom browser target, and not have to change it manually afterwards.Related Issue(s)
#9378
Fixes #9378