-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): Skip dependencies already added (avoid circular dependencies) #9744
fix(core): Skip dependencies already added (avoid circular dependencies) #9744
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/9MxPYpyPxFkFrmwti8JkCfzpf11z [Deployment for e3928c5 canceled] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! LGTM 🎉
The project utility method `collectDependentProjectNodesNames()` produces a stack overflow (e.g. producing project dependencies for `tailwind.config.js` when circular dependencies exist. Fix by adding loop detection for "already add" dependencies.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
The project utility method
collectDependentProjectNodesNames()
produces a stack overflow (e.g. producing project dependencies fortailwind.config.js
when circular dependencies exist.Fix by adding loop detection for "already added" dependencies.
Current Behavior
Currently, when a circular dependency exists, operations like (for example) a development build for an Angular app including Tailwind produces a stack overflow as follows:
Expected Behavior
Ideally, circular dependencies should be detected and recursion avoided.
Related Issue(s)
I've taken a similar approach to #2022.