Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React throws warning when rendering DateRangePicker #1035

Closed
aleksygoroszko opened this issue Feb 21, 2024 · 1 comment
Closed

React throws warning when rendering DateRangePicker #1035

aleksygoroszko opened this issue Feb 21, 2024 · 1 comment
Assignees
Labels
🔨 React Has to do with the React implementation

Comments

@aleksygoroszko
Copy link

aleksygoroszko commented Feb 21, 2024

What's wrong?

Using DateRangePicker with label results in React warning:
Warning: React does not recognize the isDisabled prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase isdisabled instead. If you accidentally passed it from a parent component, remove it from the DOM element.

How to reproduce?

Open Sandbox
yarn install
yarn dev

Steps to reproduce the behavior:

  1. Open dev console
  2. Click button to show DateRangePicker to see warning in the console

NB! The warning does not appear when label is not in use

I think that maybe isDisabled sneaks somehow in some ...restProps or some other piece of code returning such props as there is not direct usage of it in the example to be passed down to the component.

@aleksygoroszko aleksygoroszko changed the title React gives warning when rendering DateRangePicker React throws warning when rendering DateRangePicker Feb 21, 2024
@perweum perweum added the 🔨 React Has to do with the React implementation label Apr 29, 2024
@perweum
Copy link
Collaborator

perweum commented Jun 24, 2024

We want to remove the date-range picker and move the functionality to a standalone calendar component. We also want to add date-picker to the attached input component so we can still use it with this functionality in mind. Will create a new issue detailed what needs to be done.

@perweum perweum closed this as completed Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 React Has to do with the React implementation
Projects
None yet
Development

No branches or pull requests

3 participants