FullScreeenDrawer and SimpleDrawer: add props for drawer body #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ailhay
requested review from
Cmoen11,
leiferikbjorkli,
cibietici,
MikaelSvanasbakken,
alicemacl,
MTeresita and
mcklien
and removed request for
a team
🦋 Changeset detectedLatest commit: 99a3d31 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alicemacl
approved these changes
Jun 11, 2024
alicemacl
reviewed
Jun 11, 2024
ailhay
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Chakra, for drawer, sets
aria-describedbydefault value for chakra-modal to be the id of the drawer body. This creates some voiceover issues on iphone (in browser) as any child components in the drawer body that doesn't havearia-describedbyset instead uses thearia-describedbydefault value set for the entire modal.Solution
Add a prop to FullScreenDrawer and SimpleDrawer that contains props for drawer body. This will enable the user to set a specific id for drawer body that doesn't match the default
aria-describedby.