-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major change: Accordion update #1213
Conversation
🦋 Changeset detectedLatest commit: 64dc13a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Vi bruker Accordion i header menyen på vy.no, gjerne sjekk godt der når du skal få denne ut i main frontend |
@Cmoen11 Jepp. Derfor er dette en breaking change med versjonsoppdatering: Alle som oppdaterer til versjon 10 må gjennom sine accordions for å fikse. Små ting, men likevel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Background
Size prop is removed from Accordion, and uses now responsive values for mobile and desktop.
Solution
UU checks
Note: To trigger pipeline for the documentation site (spor.vy.no) you need to bump the version.
How to test
Go to /components/accordion-v2
With updated documentation for the component.