Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major change: Accordion update #1213

Merged
merged 10 commits into from
Jul 3, 2024
Merged

Major change: Accordion update #1213

merged 10 commits into from
Jul 3, 2024

Conversation

alicemacl
Copy link
Contributor

@alicemacl alicemacl commented Jul 3, 2024

Background

Size prop is removed from Accordion, and uses now responsive values for mobile and desktop.

Solution

  • Edit styling with responsive values
  • Remove size prop and context from Accordion (not needed as it was only used for the size prop)
  • Remove allowMultiple as default. Accordion ignores allowToggle when allowMultiple is true. The user can add these props manually to avoid warnings.

UU checks

  • It is possible to use the keyboard to reach your changes
  • It is possible to enlarge the text 400% without losing functionality
  • It works on both mobile and desktop
  • It works in both Chrome, Safari and Firefox
  • It works with VoiceOver
  • There are no errors in aXe / SiteImprove-plugins / Wave
  • Sanity documentation has been / will be updated (if neccessary)
  • Documentation version has been bumped (package.json in docs)

Note: To trigger pipeline for the documentation site (spor.vy.no) you need to bump the version.

How to test

Go to /components/accordion-v2

With updated documentation for the component.

@alicemacl alicemacl requested review from johnolos, ithen15 and a team as code owners July 3, 2024 09:49
@alicemacl alicemacl requested review from Cmoen11, leiferikbjorkli, cibietici, MTeresita and mcklien and removed request for a team July 3, 2024 09:49
Copy link

changeset-bot bot commented Jul 3, 2024

🦋 Changeset detected

Latest commit: 64dc13a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@vygruppen/spor-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Cmoen11
Copy link
Member

Cmoen11 commented Jul 3, 2024

Vi bruker Accordion i header menyen på vy.no, gjerne sjekk godt der når du skal få denne ut i main frontend

@alicemacl
Copy link
Contributor Author

Vi bruker Accordion i header menyen på vy.no, gjerne sjekk godt der når du skal få denne ut i main frontend

@Cmoen11 Jepp. Derfor er dette en breaking change med versjonsoppdatering: Alle som oppdaterer til versjon 10 må gjennom sine accordions for å fikse. Små ting, men likevel.

Copy link
Contributor

@cibietici cibietici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alicemacl alicemacl merged commit d906e2b into main Jul 3, 2024
2 checks passed
@alicemacl alicemacl deleted the accordion branch July 3, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify Accordion - change from 3 sizes to 1 for mobile and 1 for desktop
3 participants