Automatic conversion to scala.concurrent.duration

[kepkin]

Hi!

I'm using nscala-time with RxScala, so I had to write a simple implicit conversion:

import com.github.nscala_time.time.Imports.{ Duration => NscalaDuration }
import scala.concurrent.duration._

object NscalaDurationImplicits {
   implicit def Dur2Dur(d: NscalaDuration) : Duration = d.getStandardSeconds() seconds 
}

I think it's possible to include this conversion into nscala-time

[kepkin]

Oh I was terribly wrong!
When I write

val x = 3 seconds // type inference says it's a com.github.nscala_time.time.DurationBuilder

So I need an implicit conversion from DurationBuilder, but it's a private class! So the following just won't compile

package implicit_vs_private

import scala.concurrent.duration.{Duration => ScalaDuration}
import com.github.nscala_time.time.Imports._
import com.github.nscala_time.time.DurationBuilder

object Test {
  implicit def NscalaDurationBuilder2Duration(x: DurationBuilder) : ScalaDuration = ScalaDuration.fromNanos(x.standardDuration.getMillis * 1000000)
}

[kmizu]

Hi. There are another request to make DurationBuilder public already. Whether we accept your proposal, to implicit converion to nscala-time, or not, I'd like to make DurationBuilder public. Since DurationBuilder is mostly internal representation, it's not so good to make it public, but I'd like to do it for convenience.

What do you think? /cc: @gakuzzzz @xuwei-k @tototoshi

[gakuzzzz]

I'm your side, @kmizu. I's not so good to make it public
However, we dont have more better solution... mmm

[kmizu]

Today, I decided to make DurationBuilder public since another elegant solution could not be found.
I'll create the PR to do it.

[kmizu]

Fixed via #64

[yokomizor]

What you think about to include @kepkin conversion's into nscala-time?

I think it would be very useful.

[kmizu]

@yokomizor OK. I think it's a good idea to add @kepkin conversion's into nscala-time. Since I'm a little busy, it helps us if you create the PR to add @kepkin conversion's into nscala-time. Or please wait a while for creating the PR.

[kmizu]

@yokomizor Note that Since nscala-time is simple sbt project, I think that you can edit nscala-time code easily via text editors or IDEs (Especially, IntelliJ IDEA + Scala Plugin).

[kmizu]

@yokomizor I'm sorry to late response. After I create the PR #69 and the PR's badness is point outed, I found it bad idea that @kepkin conversions are included into nscala-time. Then, I close this issue.