-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conversion to and from scala std duration #72
conversion to and from scala std duration #72
Conversation
- provides a solution for #71 based on milliseconds - since 2.9.1 and 2.9.2 do not contain the std duration implementation, these would need to be dropped (is it still necessary to support these?) - renames DateImplicits to ConversionImplicits
Thanks for sending PR. Would you tell us more detail why DateImplicits need to rename? regards, |
We can accept that Scala 2.9.1 and 2.9.2 support is dropped. |
I thought about renaming because the new name fits better, but I revert. |
awesome! I agree that ConversionImplicits is natural name. |
Cool, LGTM. |
👍 |
conversion to and from scala std duration
these would need to be dropped (is it still necessary to support
these?)