Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conversion to and from scala std duration #72

Merged
merged 5 commits into from
Sep 26, 2014
Merged

conversion to and from scala std duration #72

merged 5 commits into from
Sep 26, 2014

Conversation

wookietreiber
Copy link
Contributor

  • provides a solution for Compatibility with scala duration #71 based on milliseconds
  • since 2.9.1 and 2.9.2 do not contain the std duration implementation,
    these would need to be dropped (is it still necessary to support
    these?)
  • renames DateImplicits to ConversionImplicits

- provides a solution for #71 based on milliseconds
- since 2.9.1 and 2.9.2 do not contain the std duration implementation,
  these would need to be dropped (is it still necessary to support
  these?)
- renames DateImplicits to ConversionImplicits
@gakuzzzz
Copy link
Member

Thanks for sending PR.

Would you tell us more detail why DateImplicits need to rename?
This change breaks compatibility.

regards,

@gakuzzzz
Copy link
Member

We can accept that Scala 2.9.1 and 2.9.2 support is dropped.
Would you fix build and travis configurations?

@wookietreiber
Copy link
Contributor Author

I thought about renaming because the new name fits better, but I revert.

@gakuzzzz
Copy link
Member

awesome!

I agree that ConversionImplicits is natural name.
But, it is a cause of discomfort that richSDuration is added into DateImplicits.
I think that is more better creating ScalaDurationImplicits instead of adding into DateImplicits.
What would you say?

cc/ @kmizu @xuwei-k @tototoshi @seratch

@gakuzzzz
Copy link
Member

Cool, LGTM.
I want to merge this.
Can I do it, @kmizu ?

@xuwei-k
Copy link
Member

xuwei-k commented Sep 26, 2014

👍

xuwei-k added a commit that referenced this pull request Sep 26, 2014
conversion to and from scala std duration
@xuwei-k xuwei-k merged commit f21ee9f into nscala-time:master Sep 26, 2014
@wookietreiber wookietreiber deleted the wip-std-duration-conversion branch September 26, 2014 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants